Repository navigation
Keep a security-audit BLOCKER that an unindented code fence follows - #1371
Open
dormouse-bot wants to merge 1 commit into
Open
dormouse-bot wants to merge 1 commit into
dormouse-bot wants to merge 1 commit into
Conversation
parseFragment reset the open finding on a column-0 fence without closing it, so the BLOCKER never reached parsed.findings and the domain's verdict was computed as if it had not been written.
Deploying mouseterm with
|
| Latest commit: |
e58fb64
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a18bcdfa.mouseterm.pages.dev |
| Branch Preview URL: | https://fix-audit-fence-drops-findin.mouseterm.pages.dev |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parseFragmentinscripts/security-audit-report.mjsdropped an open BLOCKER or WARNING when the next unindented line was a code fence. The fence branch setfinding = nullwithout callingcloseFinding, so the finding never reachedparsed.findings, anddomainVerdictjudged the fragment as if it hadn't been written (line 195). This PR closes the open finding before toggling the fence.The effect on the nightly audit: a domain that writes
VERDICT: FAIL, a fully evidenced BLOCKER, and then a column-0 fenced snippet gets INCONCLUSIVE, because its stated FAIL has no finding behind it. A domain that leftVERDICT: PASSon line 1 gets PASS, so the release gate opens on a run that reported a BLOCKER. Before the fix,parseFragmenton such a fragment returned zero findings. After it, it returns one.The test is a new
reporting:case inscripts/security-audit.test.mjs: the existing BLOCKER fixture followed by an unindented fence. It expects FAIL. Without the fix it gets INCONCLUSIVE (MISSINGfromcompose). With it, all 179 tests in the file pass, and so dosecurity-audit-canary.test.mjsandgithub-state-check.test.mjs.