docs: update accessibility article - #5380
Closed
eirikbacker wants to merge 4 commits into
Closed
eirikbacker wants to merge 4 commits into
eirikbacker wants to merge 4 commits into
Conversation
eirikbacker
commented
Sep 17, 2026
eirikbacker
commented
Contributor
- Resolving Update accessibility overview so it can be used to measure compliance support #4205
Added lists from Mattilsynet + link to Wiki. Signed-off-by: Frank Dahle <frankdahle@gmail.com>
Removed text Signed-off-by: Frank Dahle <frankdahle@gmail.com>
🦋 Changeset detectedLatest commit: 7c5a396 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Signed-off-by: Eirik Backer <eirik.backer@gmail.com>
eirikbacker
marked this pull request as ready for review
September 17, 2026 13:36
eirikbacker
requested review from
Barsnes,
Febakke,
mimarz and
mrosvik
as code owners
September 17, 2026 13:36
Contributor
|
Preview deployments for this pull request: www - |
eirikbacker
changed the title
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Several accessibility claims and compliance boundaries need correction before approval.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates the Norwegian accessibility article to clarify Designsystemet’s support and consumer responsibilities.
Changes:
- Adds categorized accessibility guidance.
- Links to the detailed WCAG overview.
- Adds documentation-only release metadata.
File summaries
| File | Summary |
|---|---|
apps/www/app/content/intro/no/accessibility.mdx |
Expands Norwegian accessibility guidance and responsibility boundaries. |
.changeset/nice-ads-change.md |
Marks the update as documentation-only. |
Review details
Suppressed comments (5)
apps/www/app/content/intro/no/accessibility.mdx:25
- These capability labels do not identify the WCAG success criteria or distinguish regulatory requirements from guidance beyond the regulation. That makes this page unsuitable as the compliance-support measure described in #4205; please map each item to its criterion and state whether support is built in, conditional on usage/theme, or left to the consumer instead of relying on the separate wiki link alone.
### Dette løser designsystemet:
- **Fokustilstander:** Tydelige og synlige fokustilstander for interaktive elementer på alle bakgrunner.
- **Fargekontrast:** Tilstrekkelig kontrast og form på innhold for både svaksynte og fargeblinde.
- **Tastaturtilgjengelighet:** Alle interaktive elementer kan nås og betjenes med tastatur.
apps/www/app/content/intro/no/accessibility.mdx:35
- Dark mode is not itself a WCAG requirement, and
data-color-scheme="auto"only follows the user's system preference; it does not make a custom theme compliant. Listing this as something every consumer must do blurs the distinction between an optional user preference and required contrast/reflow checks, which is especially problematic for a compliance-oriented overview.
- **Aktivere darkmode:** ved hjelp av `<body data-color-scheme="auto">`.
apps/www/app/content/intro/no/accessibility.mdx:19
- This sentence says the design system follows all regulated WCAG requirements, but the following section explicitly assigns semantic HTML, text alternatives, language, and other compliance work to the consumer. That overstates what adopting Designsystemet guarantees and makes the page unsuitable as a compliance measure. Please describe support for selected requirements and state that compliance also depends on implementation and content.
Designsystemet følger WCAG-kravene som inngår i regelverket for universell utforming, for å gjøre løsningene mest mulig brukervennlige for alle. Men noen ting må du som utvikler/designer sørge for selv.
apps/www/app/content/intro/no/accessibility.mdx:38
- Issue #4205 requests updating the linked Wiki overview so it can be used to measure WCAG support, but the changes shown here only add a link to that page; no WCAG mapping or requirement list is updated in this pull request. Unless the Wiki is intentionally maintained outside this change, the requested overview remains unchanged.
[I Wikien vår på GitHub finner du en detaljert oversikt over hvilke WCAG-krav Designsystemet hjelper deg å oppfylle](https://github.com/digdir/designsystemet/wiki/Designsystemet-hjelper-deg-%C3%A5-oppfylla-WCAG%E2%80%90kravane)
apps/www/app/content/intro/no/accessibility.mdx:34
<html lang="">leaves the language value empty, so it does not identify the page language and can mislead readers implementing this requirement. Show a concrete example or explicitly indicate that the value must be replaced with the page's actual language.
- **Spesifiser innholdsspråk:** ved hjelp av `<html lang="">`.
- Files reviewed: 2/2 changed files
- Comments generated: 4
- Review effort level: Lite (auto)
Note
Copilot is running an experiment and ran this review at Lite.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| ### Dette løser designsystemet: | ||
|
|
||
| - **Fokustilstander:** Tydelige og synlige fokustilstander for interaktive elementer på alle bakgrunner. | ||
| - **Fargekontrast:** Tilstrekkelig kontrast og form på innhold for både svaksynte og fargeblinde. |
| - **Fokustilstander:** Tydelige og synlige fokustilstander for interaktive elementer på alle bakgrunner. | ||
| - **Fargekontrast:** Tilstrekkelig kontrast og form på innhold for både svaksynte og fargeblinde. | ||
| - **Tastaturtilgjengelighet:** Alle interaktive elementer kan nås og betjenes med tastatur. | ||
| - **Skalerbart design:** Tilpasning til forskjellige skjermstørrelser, zoom or preferert tekststørrelse. |
| - **Tastaturtilgjengelighet:** Alle interaktive elementer kan nås og betjenes med tastatur. | ||
| - **Skalerbart design:** Tilpasning til forskjellige skjermstørrelser, zoom or preferert tekststørrelse. | ||
| - **Rolle og tilstand:** Støtte hjelpeteknologi med semantikk og ARIA-attributter. | ||
| - **Tilgjengelige skjema:** Korrekt struktur, sammenknytting og validering. |
|
|
||
| ### Dette må du sørge for selv: | ||
| - **Semantisk HTML:** Bruk passende elementer for å formidle riktig rolle og overskriftshierarki. | ||
| - **Tekstalternativer:** Beskrivende aria-label for områder og ikke-tekstlig innhold. Dette står dokumentert på de enkelte komponent-sider. |
Corrected a fiew minor errors Signed-off-by: Frank Dahle <frankdahle@gmail.com>
Contributor
Author
|
Replaced by #5382 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.