Story/cite 217 - It should be possible to create personal access tokens#301
Open
PradnyaC11 wants to merge 29 commits intodevelopfrom
Open
Story/cite 217 - It should be possible to create personal access tokens#301PradnyaC11 wants to merge 29 commits intodevelopfrom
PradnyaC11 wants to merge 29 commits intodevelopfrom
Conversation
|
Can one of the admins verify this patch? |
jdamerow
requested changes
Apr 29, 2025
| <artifactId>mockito-core</artifactId> | ||
| <version>3.12.4</version> | ||
| <scope>test</scope> | ||
| </dependency> |
Member
There was a problem hiding this comment.
all of the code related to personal access tokens should be in its own manager class not mixed in with the oauth clients. Also, I think we want only one OAuthClient (for the user) and then create multiple access token for the client, rather than multiple oauthclients. Or is there a reason to have one client per token? and then finally, I think I would consider creating a subclass for oauthclient for personal access tokens, rather than a boolean flag. but is that flag really needed? it looks like it's only used once, and with a separate manager class, it might not be necessary?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guidelines for Pull Requests
If you haven't yet read our code review guidelines, please do so, You can find them here.
Please confirm the following by adding an x for each item (turn
[ ]into[x]).Please provide a brief description of your ticket
It should be possible to create personal access tokens
... Put ticket description here and add link to ticket ...
A user should be able to create personal access tokens that they can use to use the Citesphere API. The tokens should only allow access to their own data (like any token retrieved via the authorization code flow). After being generated, a token should be visible once, after that the user can only regenerate a token if they loose it. It should be possible to delete tokens.
https://diging.atlassian.net/browse/CITE-217
Are there any other pull requests that this one depends on?
diging/citesphere-model#58
Anything else the reviewer needs to know?
... describe here ...