Skip to content

Request type detection #14

Description

@y-lohse

Hi,
i encountered a small problem, not sure if it could be considered a bug.

I'm doing my upload with a POST request — as in, the HTTP header is set to post and the resumable data is in the POST body.
However, the URL I'm sending the POST request to has a GET param as well, ie. ``htttp://localhost/upload?token=lol`. Because of that, the SimpleRequest class in Resumable.php thinks it's a GET request, tried to load the params from GET and fails.

I think it would make sense to change the code here to use the HTTP header to detect the type of request rather than the ìsset() call. What do you think? I can probably submit a PR if that's ok for you.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions