Skip to content

refactor: move feed, sign-in, account and analytics into feature slices - #95

Merged
dimslaev merged 1 commit into
masterfrom
refactor/frontend-fsd-3-features
Oct 23, 2026
Merged

dimslaev merged 1 commit into
masterfrom
refactor/frontend-fsd-3-features

Conversation

@dimslaev

Copy link
Copy Markdown
Owner

Chunk 3 of 6 of the frontend FSD + kebab-case move. Stacked on #94.

Changes

  • features/feed: ArticlesList, ArticleRow, FeedFilters, ScoreRail, LikeButton in ui/, and the filters context plus topics in model/. LikeButton lives here because ArticleRow renders it and features can't import each other.
  • features/sign-in: EmailLinkForm, SignupPanel.
  • features/account: delete account, delete confirmation, user information. These are default exports, and index.ts re-exports them as named.
  • features/analytics: the admin dashboard, chart, table and lib/format.ts.
  • Each slice has an index.ts. Imports inside a slice are relative, and imports from outside go through @/features/<name>.
  • FiltersProvider moved from _layout.tsx into the feed route. Behaviour change, as planned: filters reset when the reader leaves the feed.
  • components/Articles/Feed.tsx stays until chunk 4 dissolves it into the route.

Tests

  • feed-filters.spec.ts: new test that filters reset after leaving the feed and coming back.
  • delete-account.spec.ts (new): Cancel keeps the account, Delete signs out. It stubs the DELETE request. A real delete fails on master for any user who has signed in: DELETE /users/me hits a foreign key violation on analytics_event.user_id. That backend bug is outside this stack, so I reported it separately instead of fixing it here.

Checks

  • bun run build green. bun run lint clean apart from kebab-case warnings for components/Rails, components/Common and Feed.tsx, which move in chunk 4.
  • bun run lint:layers (Steiger): no problems.
  • Playwright: 58 passed locally.
  • pre-commit hooks pass.

Generated by Claude Code

@dimslaev
dimslaev force-pushed the refactor/frontend-fsd-2-shared branch from 7444e28 to c6d8007 Compare October 23, 2026 17:39
Base automatically changed from refactor/frontend-fsd-2-shared to master October 23, 2026 17:42
@dimslaev
dimslaev force-pushed the refactor/frontend-fsd-3-features branch from f0750aa to 1864673 Compare October 23, 2026 17:42
@claude

claude Bot commented Oct 23, 2026

Copy link
Copy Markdown

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@dimslaev
dimslaev merged commit 4b01d30 into master Oct 23, 2026
6 checks passed
@dimslaev
dimslaev deleted the refactor/frontend-fsd-3-features branch October 23, 2026 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants