Repository navigation
refactor: move feed, sign-in, account and analytics into feature slices - #95
Merged
Merged
Conversation
This was referenced Oct 23, 2026
dimslaev
force-pushed
the
refactor/frontend-fsd-2-shared
branch
from
October 23, 2026 17:39
7444e28 to
c6d8007
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Tw6MLK1HN9LphNtP6APJ2w
dimslaev
force-pushed
the
refactor/frontend-fsd-3-features
branch
from
October 23, 2026 17:42
f0750aa to
1864673
Compare
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chunk 3 of 6 of the frontend FSD + kebab-case move. Stacked on #94.
Changes
features/feed:ArticlesList,ArticleRow,FeedFilters,ScoreRail,LikeButtoninui/, and the filters context plus topics inmodel/.LikeButtonlives here becauseArticleRowrenders it and features can't import each other.features/sign-in:EmailLinkForm,SignupPanel.features/account: delete account, delete confirmation, user information. These are default exports, andindex.tsre-exports them as named.features/analytics: the admin dashboard, chart, table andlib/format.ts.index.ts. Imports inside a slice are relative, and imports from outside go through@/features/<name>.FiltersProvidermoved from_layout.tsxinto the feed route. Behaviour change, as planned: filters reset when the reader leaves the feed.components/Articles/Feed.tsxstays until chunk 4 dissolves it into the route.Tests
feed-filters.spec.ts: new test that filters reset after leaving the feed and coming back.delete-account.spec.ts(new): Cancel keeps the account, Delete signs out. It stubs the DELETE request. A real delete fails on master for any user who has signed in:DELETE /users/mehits a foreign key violation onanalytics_event.user_id. That backend bug is outside this stack, so I reported it separately instead of fixing it here.Checks
bun run buildgreen.bun run lintclean apart from kebab-case warnings forcomponents/Rails,components/CommonandFeed.tsx, which move in chunk 4.bun run lint:layers(Steiger): no problems.Generated by Claude Code