fix(vllm): window long deduplicated KV loads - #362
Open
ketor wants to merge 1 commit into
Open
Conversation
ketor
force-pushed
the
fix/vllm-long-load-dedup-windows
branch
from
August 29, 2026 19:58
6ad885a to
1569adc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
For same-host replicated-MLA loads, native GPU dedup publishes fetched results only after the enclosing
batch_get_auto_sgcompletes. A 1M-token TP8 load contains 15,624 objects and takes much longer than the default follower wait, so all eight ranks time out and independently fetch the same KV data.Change
load_window_keysto bound each native GET publicationload_window_min_keysso short requests retain one native GETDefaults remain disabled and backward-compatible.
Validation
ruff check integration/vllm/src/dfkv_vllm/worker.py integration/vllm/tests/test_worker_lifecycle.py