Skip to content

Fix nightly Playwright E2E stub drift - #63

Open
sokanacollectiveCRM wants to merge 455 commits into
disc-template:mainfrom
sokanacollectiveCRM:fix/nightly-playwright-e2e-stubs
Open

Fix nightly Playwright E2E stub drift#63
sokanacollectiveCRM wants to merge 455 commits into
disc-template:mainfrom
sokanacollectiveCRM:fix/nightly-playwright-e2e-stubs

Conversation

@sokanacollectiveCRM

Copy link
Copy Markdown

Summary

  • Update nightly Playwright specs that were failing against stale stubs (legacy { clients: [] } responses, /api/auth/me, wrong doula routes, removed verification-invoice UI).
  • Add shared helpers (e2e/helpers/e2eApiStubs.ts, e2e/helpers/doulaE2eStubs.ts) for canonical ApiResponse + cookie-mode auth stubs.
  • Align portal eligibility tests with current LeadProfileModal (readiness grid + card-on-file panel; no $1 verification invoice button).
  • Fix portfolio QuickBooks screenshot assertion (QuickBooks heading, exact match).
  • Pass VITE_API_BASE_URL/VITE_APP_BACKEND_URL to the Playwright dev server for consistent stubbing.

Test plan

  • npx playwright test e2e/ticket3-client-status-interviewed.spec.ts e2e/portal-eligibility-actions.spec.ts e2e/ticket4-notes-visibility-toggle.spec.ts e2e/ticket5-doula-view-admin-notes.spec.ts e2e/portfolio/capture-portfolio.spec.ts --project=chromium (41 passed locally)
  • Nightly scheduled workflow green on merge

Made with Cursor

appleseedcarrot and others added 30 commits May 23, 2025 11:09
… (could cause problems for others?? but haven't seen)
… (could cause problems for others?? but haven't seen)
jbony2888 and others added 27 commits August 22, 2026 19:08
Replace PHI/token/body console usage with metadata-only safeLog, add a CI gate that blocks console.log/debug regressions, and cover production no-op logger behavior with unit tests.

Co-authored-by: Cursor <cursoragent@cursor.com>
…-sensitive-logging

HIPAA-07: remove sensitive frontend console logging
Silences Radix DialogContent warning when opening a lead profile from the Leads tab.

Co-authored-by: Cursor <cursoragent@cursor.com>
…og-description

Add Lead Profile DialogDescription (a11y follow-up)
- scripts/lint-changed.mjs mirrors CI (eslint + prettier on changed files)
- Husky pre-push hook runs npm run lint:push automatically
- Fix Prettier errors blocking lint workflow on LeadProfileModal

Co-authored-by: Cursor <cursoragent@cursor.com>
…ve UI.

Use PUT /clients/:id/birth-outcomes for structured dropdown/checkbox fields and drop free-text birth_outcomes from types and profile views.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…og-description

Add pre-push lint checker + fix LeadProfileModal CI failures
…atar does not flash the default image.

Keep a local preview and loading state until the saved photo has loaded, and surface the real save error from the API.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…pload-ui

Improve profile photo upload UI and loading state
* Quiet CRM deep-link misses instead of dual error UI.

When an email link targets a missing client, return to the clients list without the list error banner or Client Not Found modal.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Fix Playwright smoke by stubbing the dedicated birth-outcomes API.

The save path moved to PUT /clients/:id/birth-outcomes, so the old client PUT stub never recorded Induction: Yes.

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Jerry Bony <info@techluminateacademy.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Remove vercel.json and update production backend URL error text for Cloud Run builds.

Co-authored-by: Cursor <cursoragent@cursor.com>
Retire Vercel deploy config from frontend-crm
…ews.

Replace public Supabase template URLs with backend signed-url/download fallbacks, and wire staff CRM login/session for Identity Platform alongside existing auth modes.

Co-authored-by: Cursor <cursoragent@cursor.com>
Apply Prettier formatting and remove unused catch bindings so the PR lint workflow passes.

Co-authored-by: Cursor <cursoragent@cursor.com>
Forward Firebase password-reset query params from /login to /auth/reset-password so admin migration emails can complete password setup.

Co-authored-by: Cursor <cursoragent@cursor.com>
…bcode-redirect

Fix Identity Platform admin reset link token routing
Ship the public signing experience, Great Vibes signature styling, signed-contract viewing in billing, and CRM navigation updates for the native contract flow.

Co-authored-by: Cursor <cursoragent@cursor.com>
…port-contracts

Add native labor support signing UI and billing contract viewing
Cast list filters to query params so Cloud Build tsc passes on main deploy.

Co-authored-by: Cursor <cursoragent@cursor.com>
…lter-types

Fix frontend deploy TypeScript build for billing filters
Password reset and admin login require VITE_AUTH_MODE=identity with Firebase web config baked into Cloud Run builds; cookie mode only hits Supabase and breaks migrated admin accounts.

Co-authored-by: Cursor <cursoragent@cursor.com>
…ity-cloudbuild

Set production Cloud Build defaults to Identity Platform auth
Capture invitation secrets from URL fragments, exchange them once for
in-memory session tokens, and route all signing API calls through
credential-free backend paths with X-Signing-Session headers.

Co-authored-by: Cursor <cursoragent@cursor.com>
…al-session-exchange

Keep signing credentials out of HTTP request URLs
Align failing specs with canonical ApiResponse wrappers, cookie-mode auth, doula dashboard routes, and UI that no longer exposes verification-invoice actions.

Co-authored-by: Cursor <cursoragent@cursor.com>
@vercel

vercel Bot commented Aug 31, 2026

Copy link
Copy Markdown

@jbony2888 is attempting to deploy a commit to the DISC NU's projects Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants