Skip to content

fix(speed_monitor): refactor _SpeedSample to extend LinkedListEntry a… #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gorniaky merged 1 commit into from
Jul 5, 2026
Merged

fix(speed_monitor): refactor _SpeedSample to extend LinkedListEntry a… #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions lib/utils/speed_monitor.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import "dart:collection";

import "package:discloud/cli/disposable.dart";

final class _SpeedSample {
final class _SpeedSample extends LinkedListEntry<_SpeedSample> {
_SpeedSample(this.units) : time = DateTime.now().microsecondsSinceEpoch;

final int time;
Expand All @@ -21,7 +21,7 @@ class SpeedMonitor implements Disposable {
this._windowDuration = const .new(seconds: 1),
});

final Queue<_SpeedSample> _queue;
final LinkedList<_SpeedSample> _queue;
final Duration _windowDuration;

@override
Expand All @@ -33,17 +33,21 @@ class SpeedMonitor implements Disposable {
double add(int totalProcessedUnits) {
final _SpeedSample last = .new(totalProcessedUnits);

_queue
..removeWhere((s) => last.time - s.time > _windowDuration.inMicroseconds)
..add(last);
_queue.add(last);

final queueIterator = _queue.iterator..moveNext();

final first = queueIterator.current;
_SpeedSample first = _queue.first;

if (first == last) return _zero;

int baseDeltaTime = last.time - first.time;

while (baseDeltaTime > _windowDuration.inMicroseconds) {
first.unlink();
first = _queue.first;
baseDeltaTime = last.time - first.time;
}

return (last.units - first.units) /
((last.time - first.time) / _windowDuration.inMicroseconds);
(baseDeltaTime / _windowDuration.inMicroseconds);
}
}
Loading