Skip to content

refactor(printer): remove generic type from IPrinter interface and Co… #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gorniaky merged 1 commit into from
Jul 6, 2026
Merged

refactor(printer): remove generic type from IPrinter interface and Co… #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/cli/context.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import "dart:io";
import "package:discloud/cli/disposable.dart";
import "package:discloud/cli/printer/console_printer.dart";
import "package:discloud/cli/printer/iprinter.dart";
import "package:discloud/cli/spin/ispin.dart";
import "package:discloud/extensions/duration.dart";
import "package:discloud/extensions/list.dart";
import "package:discloud/services/discloud/api_client.dart";
Expand Down Expand Up @@ -64,7 +63,7 @@ class CliContext implements Disposable {
final bool debug;
final DiscloudApiClient api;
final LocalStore store;
final IPrinter<ISpin> printer;
final IPrinter printer;

String get locale => localeName;

Expand Down
2 changes: 1 addition & 1 deletion lib/cli/printer/console_printer.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import "package:discloud/cli/spin/ispin.dart";

part "debug_console_printer.dart";

class ConsolePrinter implements IPrinter<ISpin> {
class ConsolePrinter implements IPrinter {
factory ConsolePrinter._debug() = _DebugConsolePrinter;

factory ConsolePrinter({bool isDebug = false}) => isDebug ? ._debug() : ._();
Expand Down
4 changes: 2 additions & 2 deletions lib/cli/printer/iprinter.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import "package:discloud/cli/disposable.dart";
import "package:discloud/cli/spin/ispin.dart";

abstract interface class IPrinter<Spin extends ISpin> implements Disposable {
Spin spin({String? text, bool start = true});
abstract interface class IPrinter implements Disposable {
ISpin spin({String? text, bool start = true});

/// [info] alias
void call(Object? object);
Expand Down
Loading