feat: find_emails on ContactGenerateRequest and --find-emails on contacts generate - #22
Merged
Merged
Conversation
quantumdark
force-pushed
the
feat/contacts-generate-find-emails
branch
from
September 16, 2026 05:51
afd4ae7 to
193e187
Compare
quantumdark
force-pushed
the
feat/contacts-generate-find-emails
branch
from
September 16, 2026 13:53
193e187 to
dffdd27
Compare
yudelevi
force-pushed
the
feat/contacts-generate-find-emails
branch
from
September 18, 2026 18:44
dffdd27 to
f30168a
Compare
…acts generate Mirrors the platform's new ContaGen option: the job runs the email finder over every named, email-less row before completing and fills email / email_status on those rows. Found addresses bill under the finder's rules; the rest of the job stays unbilled.
quantumdark
force-pushed
the
feat/contacts-generate-find-emails
branch
from
September 23, 2026 19:11
f30168a to
4c13898
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to discolike-platform work item #226 (
feat/contagen-find-emails).ContactGenerateRequest.find_emails(defaultFalse).discolike contacts generate --find-emails._generated/requests.pyin generator style;scripts/gen_requests.pywill produce the same field once the platform MR is live.scripts/check_contract.pyfails against prod until then.The PR appears safe to merge after the documented companion platform deployment makes the generated contract current.
Summary
This PR adds opt-in email discovery to contact generation across the SDK and CLI.
find_emailstoContactGenerateRequest, defaulting to disabled.contacts generate --find-emailsCLI option and forwards it to the contacts service.Reviews (1) · Last reviewed commit: "feat: find_emails on ContactGenerateRequ..."