Carry the typed_columns opt-in flag through the SDK and CLI - #31
Merged
Merged
Conversation
DiscoGen's typed-column detector (which columns run through TypeSafe judgment instead of generated prose) is picked server-side from the query text; the client only opts in with a bool, same shape as include_confidence which already made the trip last commit. Hand-added to _generated/requests.py rather than regenerated, since api-dev does not serve this field yet (same ordering constraint as include_confidence).
A PR stacked on a feature branch is as far ahead of prod as the branch it targets, but base_ref only matched "development" literally, so the stack fell through to the prod spec and reported every unreleased field as a missing one. Fork PRs still get the prod spec, since they never receive DEV_SPEC_URL.
# Conflicts: # CHANGELOG.md # packages/discolike-cli/tests/test_discogen_cli.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typed_columnsopt-in flag to the SDK and CLI, mirroring the API's DiscoGen request shapetyped_columns; the OpenAPI spec requires the field and the SDK was missing it, so this is what makes thecontractcheck passStacked on #30 — should merge first.
The PR appears safe to merge, with the new flag consistently represented and forwarded across the SDK and CLI.
Summary
This PR carries the
typed_columnsopt-in through both DiscoGen request models and both CLI commands, and documents the new capability.typed_columnsto domain-based and persona-based SDK request models.--typed-columnsand--no-typed-columnsCLI options.Reviews (1) · Last reviewed commit: "Carry the typed_columns opt-in flag thro..."