Address PR #32 review findings - #33
Merged
Merged
Conversation
A leftover conflict marker from the find_emails rebase shipped in the 0.4.0 changelog. bulk companies skipped re-excluding the resumed CSV whenever any --exclusion-query-id was passed, assuming those IDs were the run's own round lists. A customer suppression list is the common case, so the next page could return only already-written companies and stop early. The CSV is now always re-excluded. File inputs caught only FileNotFoundError and JSON errors; a directory, permission error or non-UTF-8 file escaped as a traceback instead of the CLI error envelope. The SDK mirrored the platform's per-shape geo rules but not the cross-field ones (lat/lon pairing, radius without a centre, invalid standalone radius, 10-shape total), so those failed only at the API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the four Greptile findings on #32: changelog conflict marker, bulk companies resume with --exclusion-query-id, file-input OSError/encoding errors escaping the error envelope (also queries save --input), and local geo cross-field validation mirroring the platform's parse_geo_shapes.
The PR appears safe to merge, with the targeted fixes matching existing CLI and SDK contracts.
Summary
This PR addresses the prior review findings by:
Reviews (1) · Last reviewed commit: "Address PR #32 review findings before th..."