fix: request completed notification sent to all possible approvers#399
Open
elaynelemos wants to merge 1 commit intodiscord:mainfrom
Open
fix: request completed notification sent to all possible approvers#399elaynelemos wants to merge 1 commit intodiscord:mainfrom
elaynelemos wants to merge 1 commit intodiscord:mainfrom
Conversation
elaynelemos
force-pushed
the
bugfix/completed-requests-notification
branch
from
7080e32 to
c1ce28c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes spam to approvers when a request is completed by prioritizing owners in notification, as it already happens when a request is created, with a fallback to the Access owners. Also fixes the missing implementation of notification to Slack on group request creation and completion.
Resolves #392