Skip to content

[roles_add_groups] updated visibility for "Add Groups"#429

Open
Jeff-Rowell wants to merge 1 commit intomainfrom
jeffrowell/add_groups_visibility
Open

[roles_add_groups] updated visibility for "Add Groups"#429
Jeff-Rowell wants to merge 1 commit intomainfrom
jeffrowell/add_groups_visibility

Conversation

@Jeff-Rowell
Copy link
Copy Markdown
Contributor

@Jeff-Rowell Jeff-Rowell commented May 5, 2026

Summary

Previously the Add Groups and Add Owner Groups buttons on a role page were gated by isAccessAdmin, hiding them from role owners who weren't also Access admins.

  • Visibility is now isAccessAdmin || (role owner who owns ≥1 non-role group).
  • For non-admins, the dialog's autocomplete is restricted to groups the user owns, and an info note explains that unowned groups must be added via a role request from the group's page.
  • This brings the role page in parity with the group page, where AddRoles already permits group owners (not just admins).

Testing

  • Locally stubbed isAccessAdmin to return false to simulate a non-admin role owner.
image
  • As role owner of Role-JeffTestRole who owns multiple groups, both buttons appear, the dialog shows the info note, and the autocomplete only lists owned groups.
Screenshot 2026-05-05 at 10 11 55 AM Screenshot 2026-05-05 at 10 12 03 AM

…owners that own at least one group to add any groups they own to a role. Also added a note explaining what they can add.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant