DEV: pin external dependencies and update#1073
Merged
Merged
Conversation
Vendor NodeSource and Yarn signing keys instead of fetching them during builds, and install pups from a verified local gem. Pin git-sourced build inputs to immutable commits and refresh image dependencies including ImageMagick, jemalloc, oxipng, and Redis. Use HTTPS for Redis downloads and avoid installing the extra jemalloc 5 library on non-arm64 builds.
fitzy101
approved these changes
Jun 11, 2026
fitzy101
left a comment
fitzy101
left a comment
Contributor
There was a problem hiding this comment.
Hardening these installs LGTM
| echo "2db82d1e7119df3e71b7640219b6dfe84789bc0537983c3b7ac4f7189aecfeaa jemalloc-5.3.0.tar.bz2" | sha256sum -c | ||
| tar --strip-components=1 -xjf jemalloc-5.3.0.tar.bz2 | ||
| wget -q https://github.com/jemalloc/jemalloc/releases/download/5.3.1/jemalloc-5.3.1.tar.bz2 | ||
| sha256sum jemalloc-5.3.1.tar.bz2 |
Contributor
There was a problem hiding this comment.
Is this line leftover from someone wanting to read the checksum? (I realise this was here already, but it's probably not needed?)
Member
Author
There was a problem hiding this comment.
yeah I think we can drop it... we dont need 5.3.1
Member
Author
There was a problem hiding this comment.
oh it is needed for ARM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vendor NodeSource and Yarn signing keys instead of fetching them during builds, and install pups from a verified local gem.
Pin git-sourced build inputs to immutable commits and refresh image dependencies including ImageMagick, jemalloc, oxipng, and Redis. Use HTTPS for Redis downloads and avoid installing the extra jemalloc 5 library on non-arm64 builds.