Repository navigation
Resolve strict graph settings once per relation path - #542
Merged
Merged
Conversation
lehni
enabled auto-merge (squash)
October 25, 2026 22:54
lehni
disabled auto-merge
October 25, 2026 23:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strict
insertGraph()andupsertGraph()resolve their settings per node and option:getSetting()walks allrelationsentries withmatchesRelationExpression()on every call. On a large upsert (~1,000 models, 22relationsentries) that's about 9,000 calls and 3–5 ms of 84 ms.GraphOptionsnow resolves all settings of a relation path once and keeps them in a map, since the options don't change during a write. In that measurement, the upsert took 79 ms instead of 84 ms; small graphs show no difference. No behaviour change.