Open
Conversation
FrancoLiberali
force-pushed
the
feature/gorm_compilable_queries_3
branch
3 times, most recently
from
f656b13 to
1207043
Compare
Open
FrancoLiberali
force-pushed
the
feature/gorm_compilable_queries_3
branch
2 times, most recently
from
6347990 to
fc7467b
Compare
FrancoLiberali
force-pushed
the
feature/gorm_compilable_queries_3
branch
from
fc7467b to
3aafac3
Compare
FrancoLiberali
force-pushed
the
feature/gorm_compilable_queries_3
branch
from
3aafac3 to
a9c3ead
Compare
|
Kudos, SonarCloud Quality Gate passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this pull request we add the badaas-orm module which is based on gorm and provides a compilable query system (autogenerated with badaas-cli). This module can be used both within a badaas application and independently. The rest of the badaas modules are adapted to use the orm module. Since this new module does not provide an http api, there is no e2e test. On the other hand, since the module performs queries to the database using gorm, testing it at the unit level is complicated by its dependency on the database. For these reasons, integration tests are added, where it is possible to test that the queries are correctly performed by the new module.
See after #61.
Related prs: ditrit/badaas-cli#2, ditrit/badaas-example#9