Repository navigation
messages: add LeaderSelectedQueryConfig - #4896
Merged
tgeoghegan merged 2 commits intoOct 13, 2026
Merged
tgeoghegan merged 2 commits into
tgeoghegan merged 2 commits into
Conversation
tgeoghegan
force-pushed
the
timg/leader-selected-collection-job-idempotency-key-messages
branch
2 times, most recently
from
October 13, 2026 14:15
0c13e31 to
9b29cb7
Compare
divergentdave
approved these changes
Oct 13, 2026
Comment on lines
+183
to
+189
| impl Default for LeaderSelectedQueryConfig { | ||
| fn default() -> Self { | ||
| Self { | ||
| idempotency_key: b"default idempotency key".to_vec(), | ||
| } | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
I don't think we should have a Default implementation of this, as it would be too easy to misuse. We should move this to a test-only constructor method instead.
Contributor
Author
There was a problem hiding this comment.
Good idea. Moving to a method test_default gated on feature = "test-util" also confirmed that it was only being used in test contexts.
tgeoghegan
force-pushed
the
timg/leader-selected-collection-job-idempotency-key-messages
branch
2 times, most recently
from
October 13, 2026 16:42
a327266 to
379de35
Compare
In draft-ietf-ppm-dap-20, leader selected batch mode collection jobs set an idempotency key in their query. This commit adds support for this to `janus_messages`. See ietf-wg-ppm/draft-ietf-ppm-dap#797
Provide default `LeaderSelectedQueryConfig` values in various places so that targets beyond `janus_messages` compile and tests pass. Turn off the Docker tests in CI temporarily.
tgeoghegan
force-pushed
the
timg/leader-selected-collection-job-idempotency-key-messages
branch
from
October 13, 2026 17:14
379de35 to
c1ed5e6
Compare
tgeoghegan
deleted the
timg/leader-selected-collection-job-idempotency-key-messages
branch
October 13, 2026 17:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In draft-ietf-ppm-dap-20, leader selected batch mode collection jobs set an idempotency key in their query. This commit adds support for this to
janus_messages.This PR also temporarily disables some tests, which will be re-enabled in subsequent changes.
See ietf-wg-ppm/draft-ietf-ppm-dap#797 and #4893