Full Silent Payment Implementation#145
Open
notTanveer wants to merge 8 commits into
Open
Conversation
notTanveer
changed the title
notTanveer
changed the title
Collaborator
|
It's great to make it more digestible for review! |
notTanveer
force-pushed
the
feat/silent-payments-V2
branch
from
July 13, 2026 14:34
08a5d40 to
2d1da69
Compare
Author
I did include all of your fixes. a few might have been dropped during the cleanup since I removed a number of functions we no longer needed and moved helper functions that were only used by tests into their respective test files. if you notice anything specific that's missing, let me know and I'll take another look. (i squashed the |
5 tasks
notTanveer
force-pushed
the
feat/silent-payments-V2
branch
from
July 13, 2026 20:38
2d1da69 to
043a824
Compare
- replaced None with error messages. - made Bech32DecodeError an EmbitError. - Subclass EmbitError so existing except EmbitError callers still catch malformed-address errors (e.g. script.address_to_scriptpubkey). - Restore the BIP-141 2-40 byte witness program limit in decode() and drop the sp/tsp special-casing; SP addresses are not witness programs. - Replace the 118 length cap with BIP-352's recommended 1023 so valid higher-version silent payment addresses decode; cite BIP-173/BIP-352.
notTanveer
force-pushed
the
feat/silent-payments-V2
branch
from
July 13, 2026 20:40
043a824 to
3105a96
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if not fingerprint and hasattr(root, "my_fingerprint"): | ||
| fingerprint = root.my_fingerprint | ||
| return fingerprint, True, root | ||
|
|
Co-authored-by: odudex <5049478+odudex@users.noreply.github.com>
Co-authored-by: odudex <5049478+odudex@users.noreply.github.com>
Co-authored-by: odudex <5049478+odudex@users.noreply.github.com>
notTanveer
force-pushed
the
feat/silent-payments-V2
branch
from
July 14, 2026 17:10
3105a96 to
c9f4918
Compare
|
|
||
|
|
||
|
|
||
| class SilentPaymentsPSBT(PSBT): |
Co-authored-by: odudex <5049478+odudex@users.noreply.github.com>
Co-authored-by: odudex <5049478+odudex@users.noreply.github.com>
notTanveer
force-pushed
the
feat/silent-payments-V2
branch
from
July 14, 2026 17:52
c9f4918 to
f20926b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the complete Silent Payments implementation with a clean, linear commit history to make the review process easier.. covers PRs #64, #87, #95, #96, #125, #126, #130, #133,
also includes a number of fixes by @odudex , squashed into their corresponding
feat:commits to make the review process easier.