[pull] main from appwrite:main - #268
Merged
Merged
Conversation
…ages Push messages carried no channel id, so FCM delivered every notification on the app's default channel and Android users could not mute a category. createPush and updatePush now take an optional channelId, stored alongside the other push fields in the message data. The FCM adapter sends it as android.notification.channel_id and the Appwrite adapter puts it on the envelope next to tag.
# Conflicts: # src/Appwrite/Platform/Modules/Messaging/Http/Messages/Push/Update.php
A stored channelId could not be removed: null leaves the field as it is, and an empty string failed validation. Accept an empty string on update and drop the key, so a draft or scheduled message can go back to the app's default channel. Removing the key rather than storing an empty value keeps the adapters from emitting an empty channel. Cover the channel end to end through the MQTT broker: a campaign carries it to a live subscriber, and a draft sent with its channel cleared arrives without one.
feat(messaging): carry an Android notification channel on push messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )