feat: add configurable left black safety margin for YouTube cropping …#20
Merged
feat: add configurable left black safety margin for YouTube cropping …#20
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a configurable left black safety margin feature to the YouTube video cropping functionality in make_short.sh. The feature allows users to specify a left black margin that will be overlaid on the final 1080x1920 output to prevent content from being cut off at the left edge.
- Adds
--safe-leftcommand line parameter with default value of 30 pixels - Implements validation and normalization of the margin value with proper bounds checking
- Overlays a black rectangle on the left side of the final output using FFmpeg's drawbox filter
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…in make_short.sh