fix building tests with debug compiler by rainers · Pull Request #10231 · dlang/dmd

rainers · 2019-07-27T18:49:45Z

also needs #10165 and #10158 from stable.

dlang-bot · 2019-07-27T18:49:46Z

Thanks for your pull request, @rainers!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#10231"

wilzbach · 2019-07-27T19:29:27Z

also needs #10165 and #10158 from stable

-> #10232 should help

wilzbach · 2019-07-27T19:30:46Z

We should look into enabling this on a CI (see e.g. #7528), s .t. it doesn't break again.

rainers · 2019-07-27T21:54:55Z

We should look into enabling this on a CI (see e.g. #7528), s .t. it doesn't break again.

Should I try and merge #7528 into this PR?

rainers · 2019-08-08T07:40:30Z

test/dshell/sameenv.d

-    const fromExe = readText(envFromExe);
-    const fromRun = readText(envFromRun);
+    const fromExe = readOutput(envFromExe);
+    const fromRun = readOutput(envFromRun);


@marler8997 This test from #8121 didn't work with a debug compiler.

Did you fix this issue? I'm not seeing any failures with this test in the CIs

The filtering in readOutput is necessary to remove the "DMD 2.087.1-git-1234 DEBUG" message generated by a debug build of dmd. All existing CIs use a release build (i.e. none of the asserts in the compiler is tested), but this PR changes that.

IIRC you were the main contributor of the dshell-tests, so I just wanted to note that these tests should usually use readOutput (or something similar) to process compiler output.

BTW is printing this debug string on every execution really worth it?
It seems to produce more trouble than gain.

With my other suggestion, this becomes readText(envFromRun).filterCompilerDebugMsg

BTW is printing this debug string on every execution really worth it?
It seems to produce more trouble than gain.

I agree, it's quite a nuisance with little benefit.

wilzbach

Thanks a lot! I'm already pre-approving the CI part of this.

marler8997 · 2019-08-09T07:36:17Z

test/tools/dshell_prebuilt/dshell_prebuilt.d

+/**
+read the the given `file` and remove \r and the compiler debug header.
+*/
+string readOutput(string file)


Instead of a function to read a file of compiler output, how about a function called 'filterCompilerDebugMsg'?

Good idea, I'll change it.

marler8997 · 2019-08-09T07:37:11Z

test/dshell/sameenv.d


-    const fromExe = readText(envFromExe);
-    const fromRun = readText(envFromRun);
+    const fromExe = readOutput(envFromExe);


The exe output won't have the debug message to filter out.

The output still needs to be stripped from \r otherwise the output produces duplicate newlines.

marler8997 · 2019-08-09T07:38:26Z

test/dshell/sameenv.d

-    const fromExe = readText(envFromExe);
-    const fromRun = readText(envFromRun);
+    const fromExe = readOutput(envFromExe);
+    const fromRun = readOutput(envFromRun);


With my other suggestion, this becomes readText(envFromRun).filterCompilerDebugMsg

rainers · 2019-08-09T17:04:06Z

https://dev.azure.com/dlanguage/dmd/_build/results?buildId=3982&view=logs&jobId=995050be-48e9-58a0-3553-d9a547fe6c20&taskId=3bcde2a0-396a-5c5e-c7d5-d0568bb0ee4b&lineStart=4296&lineEnd=4297&colStart=1&colEnd=1:

std.net.curl.CurlTimeoutException@std\net\curl.d(4361): Timeout was reached on handle 1F09243AE00
----------------
0x00007FF69BFECBDC in std.exception.bailOut!(std.net.curl.CurlTimeoutException).bailOut

Does anyone know how libcurl.dll is built? It seems broken since dmd 2.072, earlier versions work. Also the DLL from LDC is ok. @MartinNowak ?

rainers · 2019-08-09T17:08:06Z

See dlang/phobos#7126 for the std.math failures:

core.exception.AssertError@std\math.d(5701): unittest failure
----------------
0x00007FF69C27CE72 in d_unittestp
0x00007FF69AC73391 in std.math.__unittest_L5686_C7 at D:\a\1\phobos\std\math.d(5704)

wilzbach · 2019-08-09T20:14:27Z

Does anyone know how libcurl.dll is built? It seems broken since dmd 2.072, earlier versions work.

It's built at dlang/installer.

rainers · 2019-08-11T08:32:30Z

It's built at dlang/installer.

Thanks, now I remember. It seems to be related to the version of libcurl: https://issues.dlang.org/show_bug.cgi?id=20120

…taller/builds/26627815/artifacts

rainers · 2019-08-18T06:31:36Z

Now using libcurl from https://ci.appveyor.com/project/4wil/installer/builds/26627815/artifacts for demonstration

wilzbach · 2019-08-20T13:27:28Z

.azure-pipelines/lib.sh

+    if [ ! -f dmd2/README.TXT ]; then
+        download "http://downloads.dlang.org/releases/2.x/${HOST_DMD_VERSION}/dmd.${HOST_DMD_VERSION}.windows.7z" dmd2.7z
+        7z x dmd2.7z > /dev/null
+        download "https://ci.appveyor.com/api/buildjobs/nogriv1wq32h4jr0/artifacts/libcurl-7.65.3-WinSSL-zlib-x86-x64.zip" libcurl.zip


This won't be available forever -> let's use a version from downloads.dlang.org

rainers mentioned this pull request Jul 31, 2019

Fix issue 20089: Handle extra case in fixresult_complex87 #10247

Merged

marler8997 mentioned this pull request Aug 1, 2019

Second round of makefile/build.d consolidation #10212

Merged

rainers force-pushed the test_debug branch 15 times, most recently from 6a9b759 to 2a289a3 Compare August 8, 2019 07:35

rainers commented Aug 8, 2019

View reviewed changes

wilzbach approved these changes Aug 8, 2019

View reviewed changes

marler8997 reviewed Aug 9, 2019

View reviewed changes

wilzbach added the Review:Blocking Other Work review and pulling should be a priority label Aug 11, 2019

fix building tests with debug compiler

91af080

rainers added 5 commits August 17, 2019 09:48

azure: enable build and test of debug compiler

73df16b

interface functions don't have a unique vtbl index

e71c694

fix dshell test if run with debug compiler

798d8e7

azure: fix path to libcurl.dll

0ee6f88

make readOutput a filter on a string

dc7e5d3

rainers force-pushed the test_debug branch from 6b64d5f to dc7e5d3 Compare August 17, 2019 07:48

temporarily use libcurl from https://ci.appveyor.com/project/4wil/ins…

440cdd1

…taller/builds/26627815/artifacts

thewilsonator added the Merge:auto-merge label Aug 20, 2019

dlang-bot merged commit a9d73d6 into dlang:master Aug 20, 2019

wilzbach reviewed Aug 20, 2019

View reviewed changes

Uh oh!

Conversation

rainers commented Jul 27, 2019

Uh oh!

dlang-bot commented Jul 27, 2019

Bugzilla references

Testing this PR locally

Uh oh!

wilzbach commented Jul 27, 2019

Uh oh!

wilzbach commented Jul 27, 2019

Uh oh!

rainers commented Jul 27, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wilzbach left a comment

Choose a reason for hiding this comment

Uh oh!

marler8997 Aug 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rainers commented Aug 9, 2019

Uh oh!

rainers commented Aug 9, 2019

Uh oh!

wilzbach commented Aug 9, 2019

Uh oh!

rainers commented Aug 11, 2019

Uh oh!

rainers commented Aug 18, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

marler8997 Aug 9, 2019 •

edited

Loading