Skip to content

Fix #22663: Normalize bool bitfield to 0 or 1 during logical not optimizations#22684

Open
bscuron wants to merge 2 commits intodlang:masterfrom
bscuron:bitfield_not
Open

Fix #22663: Normalize bool bitfield to 0 or 1 during logical not optimizations#22684
bscuron wants to merge 2 commits intodlang:masterfrom
bscuron:bitfield_not

Conversation

@bscuron
Copy link
Contributor

@bscuron bscuron commented Mar 3, 2026

#22663

true = -1
false = 0

!true case:
-1 & 1 => 1
1 ^ 1 => 0

!false case:
0 & 1 => 0
0 ^ 1 => 1

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @bscuron! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#22684"

@dkorpel
Copy link
Contributor

dkorpel commented Mar 3, 2026

This looks like the wrong place to fix. TYbool is supposed to be a 1-bit integer. If accessing a bool bitfield somehow generates a value of 0b11111111 or -1 then the masking should happen before it gets into an expression. Otherwise we need to check the logic for all TYbool operations (not just 'logical not') to handle arbitrary bit patterns, which generates more bytes of code even in cases where it's not necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants