Restart inference of foreach nested functions when lowering returns#22685
Open
limepoutine wants to merge 2 commits intodlang:masterfrom
Open
Restart inference of foreach nested functions when lowering returns#22685limepoutine wants to merge 2 commits intodlang:masterfrom
limepoutine wants to merge 2 commits intodlang:masterfrom
Conversation
Contributor
|
Thanks for your pull request and interest in making D better, @limepoutine! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#22685" |
Contributor
Author
|
The buildkite failure is a true positive. PR: vibe-d/vibe-core#445 |
28cedfe to
effc9ad
Compare
effc9ad to
bcb155b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22666, also fixes #22639. Also fixes Bugzilla 19408.
I'm turning a trivial bug fix into a big feature again. This PR restarts inference when lowering returns inside a foreach, commits when returns are rewritten, and runs semantic on
opApplycalls. Not particularly maintainable because we now need to patch lowering of foreach insemantic3. Contains pattern matching on lowered ASTs, speculative inference, and a reinvented wheel of counting sort.This is not quite "full inference" yet, but quite compliant to the specs. Less compliant yet more lightweight are #22642 and #22672.