An import that reports fifteen failures and can name ten - #216
Merged
Merged
Conversation
Phase 7 of the fix plan: import and export. Studio 1000 green, 989 before. **Finding 27 was half built, which is why it was reported as absent.** The CSV path has kept every rejection since WS-36, and the window has a button that writes them beside the source with the line, the reason and the text. The JSON path filled the display list and recorded nothing - so an import of a JSON file really did report "15 failed", name ten, and have nothing to save. Both paths record now, and the rule counts the recording sites against the display sites rather than trusting either. **Step 1 said "0 columns" for every file** because the count asked ColumnMappings, which is built on step 3. It reads the parse now - and the rows themselves are drawn, which is what a preview is for: a wrong delimiter is obvious in the rows and invisible in a count. **The result of an import was painted across the line saying what the file held**, because the preview banner and the error banner were both Grid.Row="5". Two borders in one cell are drawn over each other at full opacity, in every state - the same shape as the conflict message in phase 4. The cell holds a column now. **The collision policy moved to the step it is about.** It sat on Columns beside the mapping, so that step held two unrelated decisions while Destination held one control. **The export's first frame said "0 / 0 rows" at "0.0 %"**, because the panel opens when the export starts and the rows are fetched after that. Zero out of zero is not a small number; it is no number, and the numbers wait for the total now. **Two dialogs called Export Data are two dialogs.** Export table and Export query results, in the title bar and in the Tools menu - only one of them carries the three scopes with their counts, and somebody looking in Tools for them would not have found them. And the output path can be typed as well as browsed for. The census of hard-coded values went red again, at 69 against 68: the import preview's MaxHeight. The ledger records it with its reason - a box round a block of content, so the wizard does not grow with the file. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 7 of the fix plan: import and export. Studio 1000 green, 989 before.
Finding 27 was half built, which is why it was reported as absent
The CSV path has kept every rejection since WS-36, and the window has a button that writes them
beside the source with the line, the reason and the text. The JSON path filled the display list and
recorded nothing — so a JSON import really did report 15 failed, name ten, and have nothing to
save. Both paths record now, and the rule counts recording sites against display sites rather than
trusting either.
ColumnMappings— built on step 3. It reads the parse now, and the rows themselves are drawn: a wrong delimiter is obvious in the rows and invisible in a countGrid.Row="5", so the result landed across the line saying what the file held. Two borders in one cell are drawn over each other at full opacity, in every state — the same shape as the conflict message in Phase 4The census of hard-coded values went red again at 69 against 68 (the preview's
MaxHeight); theledger records it with its reason — a box round a block of content, so the wizard does not grow with
the file.
🤖 Generated with Claude Code