A window that traps the pointer with no visible way out - #217
Merged
Merged
Conversation
Phase 8 of the fix plan, and the last of the code phases. Studio 1003 green, 1000 before. The command palette answered the keyboard and nothing else. Clicking outside did not close it, clicking the button that opened it did not close it, a single click on an entry moved the highlight and stopped there, and a double click did the same. Esc and Enter were the only way in and the only way out - which is fine for a keyboard tool and not fine for a window that has taken the pointer. A press on the scrim closes it now, unless the press landed on the palette itself: a press inside is a press on a box, a list or an entry, and closing on those would take the window away mid-use. A click on an entry runs it, the way Enter does. Neither gesture replaces a key; they stop being the only way. It was found while automating the screenshots, where it stopped the run until a key could be pressed by hand. That is the clearest statement of what was wrong with it. The plan also asked to check finding 17 here - the palette listed a multi-column index twice. It reads the tree, which reads GetIndexesAsync, which phase 1 collapsed; closed there. Phases 1 through 8 are now all in main. What is left of the plan is phase 0 - the probes that need a running Studio - and the release. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 8 of the fix plan, and the last of the code phases. Studio 1003 green, 1000 before.
The command palette answered the keyboard and nothing else: clicking outside did not close it,
clicking the button that opened it did not close it, a single click on an entry moved the highlight
and stopped there, and a double click did the same.
EscandEnterwere the only way in and out.is a press on a box, a list or an entry, and closing on those would take the window away mid-use.
Neither gesture replaces a key. They stop being the only way — which is the point: a palette is a
keyboard tool and nobody minds reaching for Esc, but a window that traps the pointer with no visible
way out is a corner somebody can get stuck in. It was found while automating the screenshots, where
it stopped the run until a key could be pressed by hand.
The plan also asked to check finding 17 here — the palette listed a multi-column index twice. It
reads the tree, which reads
GetIndexesAsync, which Phase 1 collapsed; closed there.Phases 1 through 8 are now all in
main. What is left of the plan is Phase 0 — the probes thatneed a running Studio — and the release.
🤖 Generated with Claude Code