Skip to content

The ViewModel said seven and the window drew one - #219

Merged
dmitrat merged 1 commit into
mainfrom
studio-underline
Aug 19, 2026
Merged

dmitrat merged 1 commit into
mainfrom
studio-underline

Conversation

@dmitrat

@dmitrat dmitrat commented Aug 19, 2026

Copy link
Copy Markdown
Owner

Finding 20 — the last item of the fix plan. Studio 1014 green, 1007 before.

A parse error was marked with a squiggle one character wide, under the first letter of the token,
while a missing table is underlined across its whole name. That is why the screenshot pass reported
that a parse error is not marked at all: beside ten letters, one reads as nothing. The mechanism
was never broken; the length was.

The token comes out of the message — every shape this parser produces names it in single quotes
(mismatched input 'Country', extraneous input 'x', no viable alternative at input 'xy',
missing ';' at 'SELECT'). Reading it from there keeps an engine package out of a question about
drawing; the alternative was a new field on the parser's own error type. A message with no quoted
token keeps the single character it always had — the control asserts that.

The screen taught the second half

With the executed path fixed, driving Studio showed the mark still one letter wide. Whenever the
text does not parse, the live syntax check has an answer and UpdateUnderline prefers it — and
that branch hard-coded a length of one. The first test passed because nothing had run the live check.

Both branches read the token now, and Country is underlined across the word on screen.

🤖 Generated with Claude Code

Finding 20, the last item of the fix plan. Studio 1014 green, 1007 before.

A parse error was marked with a squiggle ONE CHARACTER wide, under the first letter of the token,
while a missing table is underlined across its whole name - which is why the screenshot pass reported
that a parse error is not marked at all. The mechanism was never broken; the length was.

The token comes out of the message. Every shape this parser produces names it in single quotes -
mismatched input 'Country', extraneous input 'x', no viable alternative at input 'xy', missing ';' at
'SELECT' - so reading it from there keeps an engine package out of a question about drawing. The
alternative was to add a field to the parser's own error type. A message with no quoted token keeps
the single character the mark has always had, which the control asserts.

**The screen taught the second half.** With the executed path fixed, driving Studio showed the mark
still one letter wide: whenever the text does not parse the LIVE syntax check has an answer, and
UpdateUnderline prefers it - and that branch hard-coded a length of one. The first test passed because
nothing had run the live check. Both branches read the token now, and Country is underlined across the
word on screen.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@dmitrat
dmitrat merged commit 701581c into main Aug 19, 2026
1 check passed
@dmitrat
dmitrat deleted the studio-underline branch August 19, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant