The ViewModel said seven and the window drew one - #219
Merged
Merged
Conversation
Finding 20, the last item of the fix plan. Studio 1014 green, 1007 before. A parse error was marked with a squiggle ONE CHARACTER wide, under the first letter of the token, while a missing table is underlined across its whole name - which is why the screenshot pass reported that a parse error is not marked at all. The mechanism was never broken; the length was. The token comes out of the message. Every shape this parser produces names it in single quotes - mismatched input 'Country', extraneous input 'x', no viable alternative at input 'xy', missing ';' at 'SELECT' - so reading it from there keeps an engine package out of a question about drawing. The alternative was to add a field to the parser's own error type. A message with no quoted token keeps the single character the mark has always had, which the control asserts. **The screen taught the second half.** With the executed path fixed, driving Studio showed the mark still one letter wide: whenever the text does not parse the LIVE syntax check has an answer, and UpdateUnderline prefers it - and that branch hard-coded a length of one. The first test passed because nothing had run the live check. Both branches read the token now, and Country is underlined across the word on screen. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finding 20 — the last item of the fix plan. Studio 1014 green, 1007 before.
A parse error was marked with a squiggle one character wide, under the first letter of the token,
while a missing table is underlined across its whole name. That is why the screenshot pass reported
that a parse error is not marked at all: beside ten letters, one reads as nothing. The mechanism
was never broken; the length was.
The token comes out of the message — every shape this parser produces names it in single quotes
(
mismatched input 'Country',extraneous input 'x',no viable alternative at input 'xy',missing ';' at 'SELECT'). Reading it from there keeps an engine package out of a question aboutdrawing; the alternative was a new field on the parser's own error type. A message with no quoted
token keeps the single character it always had — the control asserts that.
The screen taught the second half
With the executed path fixed, driving Studio showed the mark still one letter wide. Whenever the
text does not parse, the live syntax check has an answer and
UpdateUnderlineprefers it — andthat branch hard-coded a length of one. The first test passed because nothing had run the live check.
Both branches read the token now, and
Countryis underlined across the word on screen.🤖 Generated with Claude Code