Skip to content

The double click was repaired onto a route that does not exist - #222

Merged
dmitrat merged 1 commit into
mainfrom
studio/double-click
Aug 19, 2026
Merged

dmitrat merged 1 commit into
mainfrom
studio/double-click

Conversation

@dmitrat

@dmitrat dmitrat commented Aug 19, 2026

Copy link
Copy Markdown
Owner

Reported: a double click on a table opens nothing - it only opens the row. It has been that way since the repair that was supposed to fix it, and it shipped in 3.1.0.

What it was

DoubleTapped is registered Bubble alone. Asking for its tunnelling route is not asking for an early handler, it is asking for no handler - AddHandler takes the route as a plain argument and cannot refuse an impossible one. The call compiled, ran, registered nothing and said nothing.

AddHandler(DoubleTappedEvent, OnDoubleTapped, RoutingStrategies.Tunnel);   // never called

The fix

The pointer is the event that does tunnel, so the double click is read from it: PointerPressed with ClickCount == 2, before the row sees the press. A press on the chevron is left alone - two clicks there are two toggles.

Handling the press does not stop the tap. The gesture is recognised from the finished route, so the row still toggled itself and a table both opened its data and opened its row. That was measured, not reasoned. A second handler - bubbling, handledEventsToo, because the row marks the tap handled - puts back the row a double click has just opened the data of. The chevron and the arrow keys are untouched.

The guard

AHandlerRunsOnlyOnARouteItsEventTravelsTests is the general rule, not this instance: every AddHandler in Studio is read out of the source, the event is resolved to the real RoutedEvent, and the route asked for must be one the event actually travels.

  • Red on the shipped code: DoubleTappedEvent travels Bubble, and the handler asks for Tunnel - the part that is not there is never called.
  • Red again with a sabotaged route (Tunnel → Direct on the pointer).
  • It names what it read - the calls found and the routes read out of them - so a walk that found nothing cannot pass.

The second case states the fact the failed repair was reasoned against: the double tap bubbles and nothing else, and the pointer tunnels.

Measured against a fresh build

  • a table opens its data and stays closed;
  • a view opens its top 1000 and stays closed;
  • the chevron still opens the columns.

Studio: 1021 green.

🤖 Generated with Claude Code

Reported: a double click on a table opens nothing, it only opens the row. It has
been that way since the repair that was supposed to fix it, and it shipped in 3.1.0.

DoubleTapped is registered Bubble ALONE. Asking for its tunnelling route is not
asking for an early handler, it is asking for no handler: AddHandler takes the route
as a plain argument and cannot refuse an impossible one, so the call compiled, ran,
registered nothing, and said nothing. From that commit the double click did nothing
at all - through 1014 green tests, a green CI and a signed release.

The pointer is the event that tunnels, so the double click is read from it:
PointerPressed with ClickCount == 2, before the row sees the press. A press on the
chevron is left alone - two clicks there are two toggles.

Handling the press does NOT stop the tap. The gesture is recognised from the finished
route, so the row still toggled itself and a table both opened its data and opened
its row - measured, not reasoned. A second handler, bubbling and handledEventsToo,
puts back the row a double click has just opened the data of. The chevron and the
arrow keys are untouched.

The guard is the general rule rather than this instance: every AddHandler in Studio
is read out of the source, the event resolved to the real RoutedEvent, and the route
asked for must be one the event actually travels. Red on the shipped code, red again
with a sabotaged route, and it names what it read so that a walk which found nothing
cannot pass.

Measured against a fresh build: a table opens its data and stays closed, a view opens
its top 1000 and stays closed, the chevron still opens the columns.

Studio: 1021 green.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@dmitrat
dmitrat merged commit 0e929cd into main Aug 19, 2026
1 check passed
@dmitrat
dmitrat deleted the studio/double-click branch August 19, 2026 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant