Skip to content

matej/vscode-header-context-parsing#465

Open
voiys wants to merge 4 commits intodmno-dev:mainfrom
voiys:matej/vscode-header-context-parsing
Open

matej/vscode-header-context-parsing#465
voiys wants to merge 4 commits intodmno-dev:mainfrom
voiys:matej/vscode-header-context-parsing

Conversation

@voiys
Copy link
Contributor

@voiys voiys commented Mar 23, 2026

Summary

  • align VS Code header detection with current @env-spec semantics by treating all comment blocks before the first config item as header scope
  • stop relying on # --- when deciding whether decorator completion should use root or item decorators
  • add focused completion-core tests for divider-separated and divider-less header blocks, including duplicate filtering across header scope

Test plan

  • bun test packages/vscode-plugin/test/completion-core.test.ts
  • bun run --filter env-spec-language test:ci
  • bun run lint:fix

Note: bun run lint:fix completed, but it still reports unrelated pre-existing warnings in packages/varlock/src/lib/load-graph.ts.

Examples:

  1. Header block before the first item stays root-scoped

01

  1. First attached block becomes item scope

02

  1. Later item blocks still behave normally
03
  1. Parser-valid item syntax ends header scope too
04

@changeset-bot
Copy link

changeset-bot bot commented Mar 23, 2026

🦋 Changeset detected

Latest commit: ee1682e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@philmillman philmillman requested a review from theoephraim March 23, 2026 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants