intellij-plugin: address automated review feedback#474
Merged
philmillman merged 2 commits intoextension/intellijfrom Mar 23, 2026
Merged
intellij-plugin: address automated review feedback#474philmillman merged 2 commits intoextension/intellijfrom
philmillman merged 2 commits intoextension/intellijfrom
Conversation
Draft
|
… patterns, .idea gitignore Co-authored-by: philmillman <3722211+philmillman@users.noreply.github.com> Agent-Logs-Url: https://github.com/dmno-dev/varlock/sessions/45f827c0-165e-457c-83dc-538993ffa1bd
Copilot
AI
changed the title
[WIP] Add initial JetBrains/IntelliJ plugin for @env-spec language
intellij-plugin: address automated review feedback
Mar 23, 2026
philmillman
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several correctness and hygiene issues identified in the initial IntelliJ plugin pass.
Kotlin fixes
EnvSpecDiagnosticsCorenow restricts decorator parsing to actual# @...comment lines via newgetDecoratorCommentText/getDecoratorCommentRangehelpers, filtering out@todo:-style labels and prose like@see. Filter regexes extracted as precompiled constants.PAREN_OPEN/PAREN_CLOSEtoEnvSpecTokenTypes;EnvSpecLexerno longer reusesEQUALSfor(and). Syntax highlighter updated accordingly.ENV_ASSIGNMENT(inspection) andENV_KEY_PATTERN(completion) now matchexport KEY=...and keys containing./-:EnvSpecCompletionContributor.getDecoratorCommentPrefixnow delegates toEnvSpecDiagnosticsCore.getDecoratorCommentText, eliminating the duplicate filter logic and ensuring parity with diagnostics.TypeScript fixes
getDecoratorCommentTextexported fromdiagnostics-core.ts;completion-core.tsdrops its duplicate implementation and wraps it viagetDecoratorCommentPrefixfor API compatibility.Housekeeping
.idea/removed from version control;.idea/and*.imladded to root.gitignore.⌨️ Start Copilot coding agent tasks without leaving your editor — available in VS Code, Visual Studio, JetBrains IDEs and Eclipse.