Couple of syntax fixes and a cache fix by dwc · Pull Request #20 · dmolsen/MIT-Mobile-Web

dwc · 2011-01-25T16:53:37Z

Hey Dave,

I'm working with the development version of Mobile Web OSP and have run into some minor issues. These three commits fix the following:

There's a minor syntax issue with the iOS detection, introduced in bdc47ff.
The LDAP query building for single terms tries to operate on an array when it actually wants a word.
Not all systems are set up to have a trailing slash on the temporary directory. The RSS cache breaks (and throws warnings) in this situation, so it's safer to ensure there is a trailing slash.

If you have any questions, please let me know! I'll probably have a few more changes soon.

dmolsen · 2011-01-25T19:13:33Z

Nice. Thanks much for the fixes. I'll pull these in tomorrow and will leave the issue open until then.

…re not specfied: Notice: Undefined index: ua in /home/dwc/src/MIT-Mobile-Web/web/api/index.php on line 38 Notice: Undefined index: callback in /home/dwc/src/MIT-Mobile-Web/web/api/index.php on line 55

Notice: Use of undefined constant nil - assumed 'nil' in /home/dwc/src/MIT-Mobile-Web/web/page_builder/detection.php on line 98

dwc · 2011-01-26T21:49:48Z

Hey Dave,

I fixed some additional PHP notices, mostly with using an undefined constant 'nil' where 'NULL' was desired.

fixes issue with calendar module appearing blank on webkit

… with nine or more items

opposed to the first occurrence in the specified time frame (i.e., the first gd:when value as used by the convertFeed method). As a workaround, expand recurring events into single events as described in the GData Calendar API: http://code.google.com/apis/calendar/data/2.0/reference.html#Parameters It's more data to download but it ensures that the events are correctly sorted for the convertFeed method.

…erwise events will show whatever previous time was given

leads to issues where there is no space betwee the year (e.g. 2011) and the time (e.g. 11:45 am).

correctly selected on the day view. Otherwise, in EST you will see events that started at e.g. 9:00 pm on the previous day.

…ield names that may change

…rrays back

…ching works

…hanks, @waynethec)

…module (thanks, @waynethec)

…to break (thanks, @waynethec)

…ixes #1)

…d to it

…ary. This avoids CAPTCHA checks under high load (http://code.google.com/apis/accounts/docs/AuthForInstalledApps.html#Using).

… to a full results page rather than the detail page for one result.

…etail page for one result.

…coding

…draw map tiles after they've finished loading.

… Windows Phone 7 to the webkit class

Daniel Westermann-Clark added 3 commits January 21, 2011 11:46

Fix syntax in iOS detection for people directory

2dc8800

Fix LDAP query building for single terms

99e5286

Ensure that the RSS cache path has a trailing slash

f519737

Daniel Westermann-Clark added 2 commits January 25, 2011 16:56

Fix a couple of PHP notices when the 'ua' and 'callback' parameters a…

fda3eeb

…re not specfied: Notice: Undefined index: ua in /home/dwc/src/MIT-Mobile-Web/web/api/index.php on line 38 Notice: Undefined index: callback in /home/dwc/src/MIT-Mobile-Web/web/api/index.php on line 55

Fix some PHP notices relating to use of undefined constant, e.g.:

7c44880

Notice: Use of undefined constant nil - assumed 'nil' in /home/dwc/src/MIT-Mobile-Web/web/page_builder/detection.php on line 98

Daniel Westermann-Clark added 23 commits January 27, 2011 15:17

Add internal request parameter to the "today's events" count request;

4809524

fixes issue with calendar module appearing blank on webkit

Fix functions include for cases where $install_path is not defined yet

b9bd3ca

Fix problem with basic templates in home module not looping correctly…

5b382d3

… with nine or more items

Fix line break on more template

65c8152

Reset the time used in templates since not all events specify it; oth…

c449f34

…erwise events will show whatever previous time was given

Don't rely on strftime to give a space before the event times. This

51d04d9

leads to issues where there is no space betwee the year (e.g. 2011) and the time (e.g. 11:45 am).

Provide the timezone offset for GData timestamps so that events are

f022d98

correctly selected on the day view. Otherwise, in EST you will see events that started at e.g. 9:00 pm on the previous day.

Use the Zend API for determining event values instead of relying on f…

8fa313a

…ield names that may change

Update a few more places to use MDB2 correctly

ef81b4f

And for good measure, set the fetch mode so that we get associative a…

accd8b7

…rrays back

Quote regular expression characters in building names so that the mat…

2c208ad

…ching works

Use the description field, not the full item, since it expects a string

31e89a0

Add space for WebKit missing in 51d04d9

9a9cbc7

Add Android 2.3 devices to webkit list

af40541

Add database port option for MySQL connections

77af703

Remove Vim swap file

2e5032e

Fix YouTube interface on touch devices so the arrow doesn't repeat (t…

5378a32

…hanks, @waynethec)

Update YouTube CSS to make text readable (thanks, @waynethec)

b5aeef7

Rename categoryURL function in hours module due to conflict with map …

87f25e3

…module (thanks, @waynethec)

Allow for non-gmail.com Google Calendar usernames

25aab06

Make calendar event URLs use full identifier so they are less likely …

a821409

…to break (thanks, @waynethec)

Simplify API for Google Calendar adapter and improve error handling (f…

37c4242

…ixes #1)

Daniel Westermann-Clark and others added 15 commits May 2, 2011 17:08

Update Zend Framework to 1.11.5-minimal

c0c5592

Do not destructively set include_path so that we can incrementally ad…

53691f8

…d to it

Add caching to calendar module via Zend_Cache

e7ae35f

Move Zend_Gdata_YouTube library to where it is actually used

fb0ae76

Add caching to youtube module

14d9149

Separate out ClientLogin use to avoid hitting API before it is necess…

d70cf75

…ary. This avoids CAPTCHA checks under high load (http://code.google.com/apis/accounts/docs/AuthForInstalledApps.html#Using).

Fixed include reference to li_item.html. Changed "More Results" to go…

d317183

… to a full results page rather than the detail page for one result.

Changed "More Results" to go to a full results page rather than the d…

45f9ec5

…etail page for one result.

Use newline instead of carriage return for import of buildings from XLS

5055573

Build query strings using http_build_query for flexibility and URL en…

321ad31

…coding

Some map tiles would not display properly in webkit. It should now re…

91680f5

…draw map tiles after they've finished loading.

Merge pull request #3 from waynethec/master

a3adc15

Rewrite RSS usage so that it can display multiple alerts better

07e34ed

Update device detection to pass iPad, BlackBerry WebKit browsers, and…

a17f1f4

… Windows Phone 7 to the webkit class

Add entries for iOS 5 and recent or upcoming Android versions

0848df6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Couple of syntax fixes and a cache fix#20

Couple of syntax fixes and a cache fix#20
dwc wants to merge 43 commits into
dmolsen:masterfrom
ufwebadmin:master

dwc commented Jan 25, 2011

Uh oh!

dmolsen commented Jan 25, 2011

Uh oh!

dwc commented Jan 26, 2011

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

dwc commented Jan 25, 2011

Uh oh!

dmolsen commented Jan 25, 2011

Uh oh!

dwc commented Jan 26, 2011

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants