Skip to content

bump crystal to 0.21 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maiha wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bump crystal to 0.21 #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
/doc/
/lib/
/libs/
/.crystal/
/.shards/
Expand Down
2 changes: 1 addition & 1 deletion shard.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ authors:

license: MIT

dependencies:
development_dependencies:
spec2:
github: waterlink/spec2.cr
version: ~> 0.9
2 changes: 1 addition & 1 deletion spec/shell_spec.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ Spec2.describe "Shell" do

it "stderr not empty" { expect(subject.stderr).not_to eq "" }
it "stderr contains error message" {
expect(subject.stderr).to match(/command not found/)
expect(subject.stderr).to match(/not found/)
Copy link
Copy Markdown
Author

@maiha maiha Mar 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, the error message depends on shell. This will relax restrictions and make pass a test on travis-ci.

}
it "stdout is empty" { expect(subject.stdout).to eq "" }

Expand Down
4 changes: 2 additions & 2 deletions src/shell.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
class Shell

def initialize(@cmd : String,
@stdout : Stdio = MemoryIO.new,
@stderr : Stdio = MemoryIO.new,
@stdout : Process::Stdio = IO::Memory.new,
@stderr : Process::Stdio = IO::Memory.new,
@fail_on_error : Bool = true
)
@status = 0
Expand Down