-
-
Notifications
You must be signed in to change notification settings - Fork 773
Moving 5 PB modules from Webpack to RS Build #6837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
valadas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RsBuild is new to me, but reading a bit about it, it is kind of a rewrite of webpack concepts but in rust, with better defaults and faster builds. As long as it does not break the builds, I am fine with this approach. As for HMR not working perfect, I think we are used to it and can live with that IMO.
uzmannazari
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
One thing that plagues DNN is our build time. This is largely due to the building of the various react projects of the PersonaBar and the common libraries behind this.
This PR switches out Webpack for RSBuild for the Servers, Seo, Security, Roles and Prompt modules. RSBuild is widely regarded as the next best thing in terms of build performance even beating Vite. In local testing building the aforementioned modules sped up from say 15 seconds to just over a second.
But the build is slightly different. For a number of modules the css used to be included in the javascript. The proposed changes all pull out the CSS to its own file. This means careful checking is needed nothing has nudged/changed/etc.
Another change is that the proposed system doesn't support hot reload. But that never worked for me in the past, so I'm not sure it's a change. If someone is using this I'd love to hear.
I'd love to hear from others what they think.
To run this:
yarn installyarn run watch --scope <modulename>For the modulename check the package.json. I.e. "prompt" for the Prompt module but "security-settings" for the Security module.