Merged
Conversation
Signed-off-by: David Gageot <david.gageot@docker.com>
rumpl
approved these changes
Mar 12, 2026
There was a problem hiding this comment.
Review Summary
Assessment: 🟢 APPROVE
Summary
This PR adds "internal_error" as a retryable pattern to handle HTTP/2 INTERNAL_ERROR stream-level errors. The implementation is correct and follows existing patterns in the codebase.
Analysis:
- ✅ The pattern correctly uses case-insensitive matching (via
strings.ToLower()) - ✅ Multi-layer defense prevents false positives: HTTP status codes are extracted first, then nonRetryablePatterns are checked
- ✅ The pattern follows precedent of other broad patterns like "timeout", "connection reset", "overloaded"
- ✅ Test case validates the positive case with a realistic HTTP/2 error format
- ✅ Code comment documents the intent clearly
No issues found. The changed code works correctly and is ready to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.