Skip to content

feat: persist generic session attributes - #3958

Merged
rumpl merged 1 commit into
docker:mainfrom
rumpl:feat/session-attributes
Aug 10, 2026
Merged

feat: persist generic session attributes#3958
rumpl merged 1 commit into
docker:mainfrom
rumpl:feat/session-attributes

Conversation

@rumpl

@rumpl rumpl commented Aug 9, 2026

Copy link
Copy Markdown
Member

Summary

  • add concurrency-safe, namespaced string attributes to sessions
  • persist attributes in SQLite and expose independent copies in lightweight summaries
  • preserve attributes across JSON round trips, metadata updates, clones, branches, and derived sessions

Compatibility

  • add forward migration 026 with an empty JSON object default
  • treat legacy NULL and empty attribute values as empty metadata

Testing

  • go test ./pkg/session/...
  • go test -race ./pkg/session/...
  • go test ./pkg/server/... ./pkg/runtime/...
  • MOONSHOT_API_KEY= task test
  • task lint
  • task build

Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
@rumpl
rumpl requested a review from a team as a code owner August 9, 2026 21:48

@docker-agent docker-agent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

@rumpl
rumpl enabled auto-merge August 9, 2026 22:00
@aheritier aheritier added area/core Core agent runtime, session management area/testing Test infrastructure, CI/CD, test runners, evaluation kind/feat PR adds a new feature (maps to feat:). Use on PRs only. labels Aug 9, 2026
@rumpl
rumpl merged commit 62522e0 into docker:main Aug 10, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/core Core agent runtime, session management area/testing Test infrastructure, CI/CD, test runners, evaluation kind/feat PR adds a new feature (maps to feat:). Use on PRs only.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants