feat issue #134: support linux mint by checking /etc/os-release for ID_LIKE and UBUNTU_CODENAME#185
Open
ptandler wants to merge 3 commits intodocker:masterfrom
Open
feat issue #134: support linux mint by checking /etc/os-release for ID_LIKE and UBUNTU_CODENAME#185ptandler wants to merge 3 commits intodocker:masterfrom
ptandler wants to merge 3 commits intodocker:masterfrom
Conversation
… for ID_LIKE and UBUNTU_CODENAME Signed-off-by: Peter Tandler <p.github@tandlers.de>
33a82d2 to
ec1c828
Compare
Author
|
alright, seems like ubuntu and other use these fields as well :-( Thought it was easy. |
Signed-off-by: Peter Tandler <p.github@tandlers.de>
see https://www.shellcheck.net/wiki/SC2153 Signed-off-by: Peter Tandler <p.github@tandlers.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just tried to install docker under mint 20 and this script failed: it was detected as debian.
Luckily, Mint provides information about the base distro in
/etc/os-release:I wasn't able to test this on all other distros. However, assuming that the entries in /etc/os-release are standardized, the changes should be safe.