-
Notifications
You must be signed in to change notification settings - Fork 1.7k
chore: update docker-agent-action to v2.0.7 #3433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
docker-agent
wants to merge
1
commit into
docker:main
Choose a base branch
from
docker-agent:auto/update-docker-agent-action
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2
−2
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[medium/security]
actions: writeis broader than needed — artifact download only requiresactions: readThis PR changes
actions: readtoactions: writeon thereviewjob, with the comment "Download artifacts from trigger workflow". However, downloading artifacts is a read operation —actions: readis sufficient forgh run downloadandactions/download-artifact.actions: writeadditionally grants the ability to cancel, re-run, create, and delete workflow runs and artifacts across the repository. Since this is a reusable workflow caller, the permissions declared here form the ceiling for the callee (docker/docker-agent-action). There is no evidence in the diff that v2.0.5 genuinely requires write access — the comment still says "Download artifacts from trigger workflow", which is a read operation.If the callee workflow truly requires
actions: write(e.g. to delete artifacts after processing), this should be confirmed against the v2.0.5 release notes before merging. If not confirmed, consider reverting toactions: readto follow the principle of least privilege.