Skip to content

remove permissions block in reusable workflows #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crazy-max merged 1 commit into from
Dec 1, 2025
Merged

remove permissions block in reusable workflows #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 3 additions & 18 deletions .github/workflows/.test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

permissions:
contents: read

on:
workflow_dispatch:
push:
Expand All @@ -22,7 +19,6 @@ jobs:
uses: ./.github/workflows/build.yml
permissions:
contents: read
packages: write
id-token: write
with:
output: image
Expand Down Expand Up @@ -57,7 +53,6 @@ jobs:
uses: ./.github/workflows/build.yml
permissions:
contents: read
packages: write
id-token: write
with:
output: image
Expand Down Expand Up @@ -94,8 +89,8 @@ jobs:
uses: ./.github/workflows/build.yml
permissions:
contents: read
packages: write
id-token: write
packages: write
with:
output: image
push: ${{ github.event_name != 'pull_request' }}
Expand Down Expand Up @@ -128,7 +123,6 @@ jobs:
uses: ./.github/workflows/build.yml
permissions:
contents: read
packages: write
id-token: write
with:
output: image
Expand Down Expand Up @@ -162,7 +156,6 @@ jobs:
uses: ./.github/workflows/build.yml
permissions:
contents: read
packages: write
id-token: write
with:
output: image
Expand Down Expand Up @@ -197,8 +190,8 @@ jobs:
uses: ./.github/workflows/build.yml
permissions:
contents: read
packages: write
id-token: write
packages: write
with:
output: image
push: ${{ github.event_name != 'pull_request' }}
Expand Down Expand Up @@ -239,7 +232,6 @@ jobs:
uses: ./.github/workflows/build.yml
permissions:
contents: read
packages: write
id-token: write
with:
output: local
Expand All @@ -261,7 +253,6 @@ jobs:
uses: ./.github/workflows/build.yml
permissions:
contents: read
packages: write
id-token: write
with:
output: local
Expand All @@ -282,7 +273,6 @@ jobs:
uses: ./.github/workflows/build.yml
permissions:
contents: read
packages: write
id-token: write
with:
runner: amd64
Expand All @@ -298,7 +288,6 @@ jobs:
uses: ./.github/workflows/bake.yml
permissions:
contents: read
packages: write
id-token: write
with:
context: test
Expand Down Expand Up @@ -335,7 +324,6 @@ jobs:
uses: ./.github/workflows/bake.yml
permissions:
contents: read
packages: write
id-token: write
with:
context: test
Expand Down Expand Up @@ -372,8 +360,8 @@ jobs:
uses: ./.github/workflows/bake.yml
permissions:
contents: read
packages: write
id-token: write
packages: write
with:
context: test
target: hello-cross
Expand Down Expand Up @@ -416,7 +404,6 @@ jobs:
uses: ./.github/workflows/bake.yml
permissions:
contents: read
packages: write
id-token: write
with:
context: test
Expand All @@ -439,7 +426,6 @@ jobs:
uses: ./.github/workflows/bake.yml
permissions:
contents: read
packages: write
id-token: write
with:
context: test
Expand All @@ -462,7 +448,6 @@ jobs:
uses: ./.github/workflows/bake.yml
permissions:
contents: read
packages: write
id-token: write
with:
runner: amd64
Expand Down
10 changes: 0 additions & 10 deletions .github/workflows/bake.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,6 @@ env:
jobs:
prepare:
runs-on: ubuntu-24.04
permissions:
contents: read
outputs:
includes: ${{ steps.set.outputs.includes }}
steps:
Expand Down Expand Up @@ -273,10 +271,6 @@ jobs:
runs-on: ${{ matrix.runner }}
needs:
- prepare
permissions:
contents: read
id-token: write # for signing attestation manifests and/or registry authentication with GitHub OIDC Token
packages: write # for pushing manifests to GHCR if needed
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -657,10 +651,6 @@ jobs:

finalize:
runs-on: ubuntu-24.04
permissions:
contents: read
id-token: write # for registry authentication with OIDC if needed
packages: write # for pushing to GHCR when merging manifests if needed
outputs:
cosign-version: ${{ env.COSIGN_VERSION }}
cosign-verify-commands: ${{ steps.set.outputs.cosign-verify-commands }}
Expand Down
10 changes: 0 additions & 10 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,8 +160,6 @@ env:
jobs:
prepare:
runs-on: ubuntu-24.04
permissions:
contents: read
outputs:
includes: ${{ steps.set.outputs.includes }}
steps:
Expand Down Expand Up @@ -227,10 +225,6 @@ jobs:
runs-on: ${{ matrix.runner }}
needs:
- prepare
permissions:
contents: read
id-token: write # for signing attestation manifests and/or registry authentication with GitHub OIDC Token
packages: write # for pushing manifests to GHCR if needed
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -551,10 +545,6 @@ jobs:

finalize:
runs-on: ubuntu-24.04
permissions:
contents: read
id-token: write # for registry authentication with OIDC if needed
packages: write # for pushing to GHCR when merging manifests if needed
outputs:
cosign-version: ${{ env.COSIGN_VERSION }}
cosign-verify-commands: ${{ steps.set.outputs.cosign-verify-commands }}
Expand Down
10 changes: 4 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,8 @@ on:
build:
uses: docker/github-builder-experimental/.github/workflows/build.yml@main
permissions:
contents: read
id-token: write # for signing attestation manifests and registry authentication if needed with GitHub OIDC Token
packages: write # for pushing manifests to GHCR if needed (caller must provide the same permissions used in the reusable workflow)
contents: read # to fetch the repository content
id-token: write # for signing attestation manifests with GitHub OIDC Token
with:
output: image
push: ${{ github.event_name != 'pull_request' }}
Expand Down Expand Up @@ -91,9 +90,8 @@ on:
bake:
uses: docker/github-builder-experimental/.github/workflows/bake.yml@main
permissions:
contents: read
id-token: write # for signing attestation manifests and registry authentication if needed with GitHub OIDC Token
packages: write # for pushing manifests to GHCR if needed (caller must provide the same permissions used in the reusable workflow)
contents: read # to fetch the repository content
id-token: write # for signing attestation manifests with GitHub OIDC Token
with:
output: image
push: ${{ github.event_name != 'pull_request' }}
Expand Down