Skip to content

Expose Shutdown method for graceful stopping #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
clinta wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Expose Shutdown method for graceful stopping #102

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions sdk/handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package sdk

import (
"context"
"crypto/tls"
"fmt"
"net"
Expand All @@ -13,7 +14,8 @@ const activatePath = "/Plugin.Activate"
// Handler is the base to create plugin handlers.
// It initializes connections and sockets to listen to.
type Handler struct {
mux *http.ServeMux
mux *http.ServeMux
server *http.Server
}

// NewHandler creates a new Handler with an http mux.
Expand All @@ -25,16 +27,21 @@ func NewHandler(manifest string) Handler {
fmt.Fprintln(w, manifest)
})

return Handler{mux: mux}
server := &http.Server{
Handler: mux,
}

return Handler{mux: mux, server: server}
}

// Serve sets up the handler to serve requests on the passed in listener
func (h Handler) Serve(l net.Listener) error {
server := http.Server{
Addr: l.Addr().String(),
Handler: h.mux,
}
return server.Serve(l)
h.server.Addr = l.Addr().String()
return h.server.Serve(l)
}

func (h Handler) Shutdown(ctx context.Context) error {
return h.server.Shutdown(ctx)
}

// ServeTCP makes the handler to listen for request in a given TCP address.
Expand Down