Skip to content

fix: improve data saving logic in search.js#2734

Open
sy-records wants to merge 1 commit into
docsifyjs:developfrom
sy-records:fix/2674
Open

fix: improve data saving logic in search.js#2734
sy-records wants to merge 1 commit into
docsifyjs:developfrom
sy-records:fix/2674

Conversation

@sy-records
Copy link
Copy Markdown
Member

Summary

Related issue, if any:

Close #2674
Close #2689, Thanks @Bowl42
Close #2675, Thanks @kokovtsev

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

For any code change,

  • Related documentation has been updated, if needed
  • Related tests have been added or updated, if needed

Does this PR introduce a breaking change?

  • Yes
  • No

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge

@vercel
Copy link
Copy Markdown

vercel Bot commented May 25, 2026

@sy-records is attempting to deploy a commit to the Docsify Team on Vercel.

A member of the Team first needs to authorize it.

@sy-records sy-records requested a review from paulhibbitts May 25, 2026 02:33
@vercel
Copy link
Copy Markdown

vercel Bot commented May 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docsify-preview Ready Ready Preview, Comment May 25, 2026 2:35am

Copy link
Copy Markdown
Member

@paulhibbitts paulhibbitts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking on this PR @sy-records ! I had a difficult time in trying to replicate search failures in codesandbox with a broken page so I created two GitHub Pages test repos based on the example provided by @kokovtsev after verifying locally.

Search index test (RC) - search for 'ipsum' fails:
https://github.com/paulhibbitts/docsify-v5-search-index-RC
https://paulhibbitts.github.io/docsify-v5-search-index-RC/#/

Search index test (PR preview build) - search for 'ipsum' succeeds:
https://github.com/paulhibbitts/docsify-v5-search-index-PR
https://paulhibbitts.github.io/docsify-v5-search-index-PR/#/

Hope you can also confirm these tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search indexing does not work if some links are broken

2 participants