fix: improve data saving logic in search.js#2734
Conversation
|
@sy-records is attempting to deploy a commit to the Docsify Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
paulhibbitts
left a comment
There was a problem hiding this comment.
Thanks for taking on this PR @sy-records ! I had a difficult time in trying to replicate search failures in codesandbox with a broken page so I created two GitHub Pages test repos based on the example provided by @kokovtsev after verifying locally.
Search index test (RC) - search for 'ipsum' fails:
https://github.com/paulhibbitts/docsify-v5-search-index-RC
https://paulhibbitts.github.io/docsify-v5-search-index-RC/#/
Search index test (PR preview build) - search for 'ipsum' succeeds:
https://github.com/paulhibbitts/docsify-v5-search-index-PR
https://paulhibbitts.github.io/docsify-v5-search-index-PR/#/
Hope you can also confirm these tests.
Summary
Related issue, if any:
Close #2674
Close #2689, Thanks @Bowl42
Close #2675, Thanks @kokovtsev
What kind of change does this PR introduce?
For any code change,
Does this PR introduce a breaking change?
Tested in the following browsers: