fix(embed): strip front matter from included markdown#2752
Conversation
|
@sy-records is attempting to deploy a commit to the Docsify Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
paulhibbitts
left a comment
There was a problem hiding this comment.
Thanks very much @sy-records ! I was unsure how to duplicate this issue on Codesandbox, so I used the provided PR preview and screenshots from the originating issue.
I reviewed the original PR and confirmed the issue is on the most recent RC.4 release:
https://preview.docsifyjs.org/#/embed-files
Looking at the PR preview, I can confirm that the included Markdown is now stripped and is not included in the rendered Sidebar:
https://docsify-preview-git-fork-sy-records-fix-front-matter-docsifyjs.vercel.app/preview/#/embed-files
Summary
Related issue, if any:
Close #2654
What kind of change does this PR introduce?
For any code change,
Does this PR introduce a breaking change?
Tested in the following browsers: