Build DocumentDB images from custom gitHub sources#354
Open
hossain-rayhan wants to merge 2 commits intodocumentdb:mainfrom
Open
Build DocumentDB images from custom gitHub sources#354hossain-rayhan wants to merge 2 commits intodocumentdb:mainfrom
hossain-rayhan wants to merge 2 commits intodocumentdb:mainfrom
Conversation
Signed-off-by: Rayhan Hossain <rhossain@microsoft.com>
hossain-rayhan
requested review from
WentingWu666666,
alaye-ms and
xgerman
as code owners
Collaborator
guanzhousongmicrosoft
left a comment
guanzhousongmicrosoft
left a comment
There was a problem hiding this comment.
the PR is fine, but please set up the github repo so only admin/maintainers can start the build, so approve the build started by external contributors, to protect malicious PR and workflow build
Contributor
There was a problem hiding this comment.
Pull request overview
Enables building DocumentDB extension and gateway images using configurable upstream sources for personal testing.
Changes:
- Adds
workflow_dispatchinputs to override the DocumentDB release repo and gateway source image repo. - Updates workflow-level env vars to derive
DOCUMENTDB_RELEASE_REPOandGATEWAY_SOURCE_IMAGE_REPOfrom those inputs.
Signed-off-by: Rayhan Hossain <rhossain@microsoft.com>
Collaborator
Author
Allowed to modify only the repo/image name, not the owner. Now fork owner can only run workflow with their fork image and same for documentdb official repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed for personal testing.