Added tests for $anyElementTrue and $allElementTrue#122
Merged
eerxuan merged 2 commits intodocumentdb:mainfrom Apr 20, 2026
Merged
Added tests for $anyElementTrue and $allElementTrue#122eerxuan merged 2 commits intodocumentdb:mainfrom
eerxuan merged 2 commits intodocumentdb:mainfrom
Conversation
fanyangv
suggested changes
Apr 17, 2026
Collaborator
fanyangv
left a comment
fanyangv
left a comment
There was a problem hiding this comment.
The file organization differs between the two operators. $anyElementTrue has dedicated _null_missing.py and _scale.py files, while $allElementsTrue embeds those tests in _invalid.py and _core.py respectively. Conversely,
$allElementsTrue has a dedicated _truthiness.py while $anyElementTrue puts truthiness tests in _core.py. Consider aligning the file structure so both operators follow the same split — it makes it easier to verify coverage
parity and navigate the tests.
Signed-off-by: Victor Tsang <vitsangp@amazon.com>
vic-tsang
force-pushed
the
any/allElementTrue/tests
branch
from
0df452d to
09715b3
Compare
Collaborator
Author
|
rebased and fixed folder structure |
fanyangv
approved these changes
Apr 20, 2026
eerxuan
approved these changes
Apr 20, 2026
eerxuan
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains
Ref: