Open
Conversation
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
| ), | ||
| CommandTestCase( | ||
| "ttl", | ||
| setup=lambda db: ( |
There was a problem hiding this comment.
All 6 test functions have an identical 9-line body (setup → insert → ctx → execute → assert). can we Extract to a shared run_command_test(database_client, collection, test) helper in commands/utils/ to reduce duplication.
sathvikprasad97
suggested changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds tests for the
$dropoperator.It introduces a new
CommandTestCaseclass which is intended to be shared by all collection command tests. The big difference from existing classes likeExpressionTestCaseis that collection command tests tend to need fixture data as part of the test case. To resolve this I've provided the ability to use aCallableto get information about the fixtures while defining the test case. Similar toStageTestCase, asetuphook is also provided to configure prerequisites like specifically named collections.I also had to modify
assertResultto allowraw_resto be punched through toassertSuccess.