Merged
Conversation
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
manojnks
reviewed
Apr 15, 2026
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
…th tests Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Collaborator
Author
|
Due to the new integration test changes, this PR needs #68 to be merged first. It adds the |
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Collaborator
Author
|
The #68 dependency was merged, so this should now be ready for final review. |
manojnks
approved these changes
Apr 16, 2026
eerxuan
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds test cases for the
$sortaggregation stage, organized into files by property group:test_sort_basic_ordering.py: ascending/descending ordering for all BSON types, equal-value tiebreakingtest_sort_numeric.py: cross-type numeric interleaving (int32, int64, double, Decimal128)test_sort_type_comparison.py: BSON type comparison order, within-type ordering rulestest_sort_arrays.py: array sort key extraction (min for asc, max for desc), empty/nested arraystest_sort_key_resolution.py: compound sort left-to-right precedence, null/missing field behaviortest_sort_field_paths.py: dot notation traversal, array-of-objects extraction, field name acceptancetest_sort_direction_values.py: accepted sort order values (int64, double truncation, Decimal128 rounding,$meta)test_sort_order_errors.py: sort order type errors, range errors, error precedencetest_sort_spec_errors.py: non-object/empty spec validation, field path validation, compound key limit, duplicate keystest_sort_meta_errors.py:$metanon-meta object, extra keys, and invalid value errorstest_stages_position_sort.py: pipeline position behavior,$metasort with prerequisite stages ($text,$geoNear)As part of this change I also:
build_raw_bson_dochelper for constructing BSON documents with duplicate keysPlease note this change introduces similar machinery to #68, and a rebase will be required once one or the other is merged.
Ref: #34