Add ClamAV mirror overrides for definition downloads#304
Open
Add ClamAV mirror overrides for definition downloads#304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
freshclamdownloads virus definitions, which causes Docker image builds to fail.freshclamat alternative mirrors and add retry/timeouts so definition fetches are more resilient during CI builds.Description
CLAMAV_MIRRORandCLAMAV_MIRROR_FALLBACKand use them to generate a temporaryfreshclamconfig withMaxAttempts,ConnectTimeout, andReceiveTimeoutbefore runningfreshclamin the builder stage (cdk/Dockerfile).buildArgs(getDockerBuildArgs())to theDockerImageAssetand sourcing values from environment variables inClamavLambdaStack(cdk/src/main/java/.../ClamavLambdaStack.java).CLAMAV_MIRRORandCLAMAV_MIRROR_FALLBACKinREADME.mdso CI (e.g., GitHub Actions) can be directed to private or alternate mirrors.cdk/Dockerfile,cdk/src/main/java/cloud/cleo/clamav/cdk/ClamavLambdaStack.java, andREADME.md.Testing
mvn/cdk synth/Docker build were not run in CI for this PR).Codex Task