Repository navigation
fix(index): keep indexing when one session exceeds a sync frame - #121
Merged
Merged
Conversation
emit() builds a complete msgs replacement per session and refuses with TooLarge when the rows exceed one 1 MiB frame. The index runs all transcripts in one transaction, so a single oversized session rolled the whole run back: on one store a 2.3 MB session froze the index at 295 sessions while newer transcripts piled up unindexed. A session with no valid msgs operation now stays indexed locally and only its msgs operation is skipped; the session upsert is still emitted. Every other error still aborts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One session whose messages exceed the 1 MiB sync frame made emit() fail with TooLarge and roll back the whole index transaction, freezing every other session (295 sessions on one store while newer transcripts piled up). The oversized session is now indexed locally and only its msgs operation is skipped. Release 0.62.15.