Switch to using LazyCollection / Generators#18
Open
godismyjudge95 wants to merge 1 commit intodoefom:mainfrom
Open
Switch to using LazyCollection / Generators#18godismyjudge95 wants to merge 1 commit intodoefom:mainfrom
godismyjudge95 wants to merge 1 commit intodoefom:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reworks how the entries/users are retrieved and added to the export to use the FromGenerator concern - https://docs.laravel-excel.com/3.1/exports/from-generator.html
Without using the Generator exporter all the entries must be loaded into memory (in a collection) which can lead to hitting the memory limit when exporting a large number of entries.
I've kept basically all the same logic it just moves things around so that it is compatible with generators/lazy collections.
Let me know if there is something else you'd like me to change.