Record at the code what W5 measured about the list - #29
Merged
Merged
Conversation
W5 of the performance series closed without a change in behaviour: the list's reaction and the scope switch have no lever on our side. Written beside the code so the next outside report does not propose them again. - RowList.Reconcile: the note said 143 ms and "still open where it goes". In process, with nothing polling the window, a query over 774 entries is a median of 25-55 ms, and our code is 2-4% of the interface thread in a managed profile and in kernel samples. The rest is WPF taking new rows. - Themes/Marks.xaml: one shared Binding per mark takes a row from 13 trigger bindings to 3 and did not move the query or scroll time. Not adopted. - MainViewModel.Scope: a scope move costs 33-68 ms (median), a reset could save at most the difference on one pair and breaks A10 elsewhere. Reread on a "Moved" tick is 0.7-1.0 ms against 0.3-0.5 ms for Apply alone. Comments only. No test, contract or behaviour changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
W5 of the performance series after the external report of 2026-09-28 (items G-1, G-2, G-3, G-9). Every lever was measured, and none of them is worth a change to the product. This PR records the results beside the code they are about, so the next outside report does not propose them a third time.
Comments only. No behaviour, test or contract changes.
What was measured, all inside the process with nothing polling the window, Release build, 774 entries:
RowList.Reconcilestill said 143 ms and "open where it goes" - replaced.Bindingobject. Query and scroll times did not move (interleaved runs, overlapping ranges). Not adopted - noted inThemes/Marks.xaml.MainViewModel.Scope.Rereadon a "Moved" tick is 0.7-1.0 ms against 0.3-0.5 ms forApplyalone. Kept - noted atReread.Checked: architecture tests 182/182,
MarkDistinctionGuards7/7.🤖 Generated with Claude Code