Keep a running plan's sheet, report and readings intact - #32
Merged
Merged
Conversation
Package A of the stability review: G-1, G-2, G-5, G-6 and a defence for X-1. - While a plan is being carried out, Escape, the close mark, a new preview and the details panel no longer put the plan sheet away. Putting it away lowered the busy flag while the run went on, so a second run could start beside the first, after which the close guard and Interrupt followed only the second one. The close mark is greyed with a tooltip saying why, Escape is taken and does nothing, a preview or the details are refused with the reason in the status line, and the window also refuses a second run while it holds one. - The list is refreshed after the run has been recorded and outside the catch meant for a refused plan, so a refresh that throws no longer replaces the run's report with an empty one. A run that carried nothing out says so instead of "Done. All 0 entries are where you asked." - A full reading asked for while another is out is owed and carried out after it, instead of being dropped. The reading after a plan could vanish under a tick and leave the Startup type column stale until F5. - A tick that works after one that failed brings the status line and the empty list face back at once. - A name handed over twice in one reading becomes one row. Tests: RunHoldsTheSheetGuards and OwedReadingTests. One assertion in MainViewModelTests now expects the owed second reading, one after the other. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Package A of an internal stability review of the window.
How it was checked
RunHoldsTheSheetGuards(4, on a live window with a held run) andOwedReadingTests(3).MainViewModelTests.Two_readings_are_never_out_at_oncenow expects the second reading to follow the first rather than be dropped.Not covered
InvalidOperationExceptionany more.🤖 Generated with Claude Code